Skip to content

feature: add add sub_dir to CSV logger constructor #21045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

feature: add add sub_dir to CSV logger constructor #21045

wants to merge 6 commits into from
+90 −2

Conversation

Shoumik-Gandre
Copy link

@Shoumik-Gandre Shoumik-Gandre commented Aug 11, 2025 •
edited
Loading

What does this PR do?

Fixes #21035

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs) yes
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--21045.org.readthedocs.build/en/21045/

@github-actions github-actions bot added the fabric lightning.fabric.Fabric label Aug 11, 2025
@Shoumik-Gandre Shoumik-Gandre marked this pull request as ready for review August 11, 2025 02:11
deependujha
deependujha reviewed Aug 11, 2025
View reviewed changes
deependujha
deependujha previously approved these changes Aug 11, 2025
View reviewed changes
Copy link
Collaborator

@deependujha deependujha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @Shoumik-Gandre.

Could you also update lightning/pytorch/loggers/csv_logs so this behavior is consistent across both Fabric and the Trainer?

@deependujha deependujha dismissed their stale review August 11, 2025 03:37

didn't wanted to approve for now, and wait for test results

bhimrazy
bhimrazy reviewed Aug 11, 2025
View reviewed changes
@codecov Codecov
Copy link

codecov bot commented Aug 11, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87%. Comparing base (daed436) to head (8b073d6).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff            @@
##           master   #21045     +/-   ##
=========================================
+ Coverage      49%      87%    +38%     
=========================================
  Files         265      268      +3     
  Lines       23268    23333     +65     
=========================================
+ Hits        11322    20323   +9001     
+ Misses      11946     3010   -8936

@Borda Borda changed the title feature: add add sub_dir to csv logger constructor feature: add add sub_dir to CSV logger constructor Aug 11, 2025
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Aug 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhimrazy bhimrazy bhimrazy approved these changes

@deependujha deependujha deependujha left review comments

@lantiga lantiga lantiga approved these changes

@Borda Borda Borda approved these changes

@williamFalcon williamFalcon Awaiting requested review from williamFalcon williamFalcon is a code owner

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@ethanwharris ethanwharris Awaiting requested review from ethanwharris ethanwharris is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add sub_dir to csv logger constructor
5 participants
@Shoumik-Gandre @lantiga @Borda @bhimrazy @deependujha